Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat($markdown): cache parser (#1359)" #1596

Merged
merged 1 commit into from
May 12, 2019
Merged

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented May 12, 2019

This reverts commit f04adbf.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

  • Before (The TOC rendered correctly):

image

  • After (The TOC rendered correctly):

image

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz
Copy link
Member Author

ulivz commented May 12, 2019

// cc @shigma

@ulivz ulivz merged commit fda5476 into master May 12, 2019
@BuptStEve
Copy link
Contributor

This PR introduced a breaking change to my plugin...BuptStEve/markdown-it-vuese#3

@ulivz ulivz deleted the feat/revert-1359 branch June 4, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants