Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reenable search #1832

Merged
merged 1 commit into from
Sep 6, 2019
Merged

feat: reenable search #1832

merged 1 commit into from
Sep 6, 2019

Conversation

s-pace
Copy link
Contributor

@s-pace s-pace commented Sep 3, 2019

cc #697

s-pace pushed a commit to algolia/docsearch-configs that referenced this pull request Sep 3, 2019
cc vuejs/vuepress#1832
0e59e75
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

The doc actually working but i didnt know about algolia part. You just tried in local ?

As long as i know algolia scrap the website to have informations and make the search working.

Is it up to date ?

@sarahdayan I am sure you have informations ^^

@flozero flozero added complexity: easy Easy complexity status: core team assigned Core team member assigned topic: docs Used when working with docs type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@s-pace
Copy link
Contributor Author

s-pace commented Sep 6, 2019

👋 @f3ltron

The vuepress website is currently using the javascript search. This PR enables the Docsearch search experience instead. It comes with some extra-feature such as typo tolerance.

Your DocSearch index vuepress is up to date. Here is the output of your crawl:

image

@flozero
Copy link
Collaborator

flozero commented Sep 6, 2019 •
edited
Loading

I just didnt see you came from algolia ^^. Top i validate it. We will release it soon

Thank's @s-pace

@flozero flozero merged commit 712deac into vuejs:master Sep 6, 2019
@vue-bot
Copy link

vue-bot commented Sep 6, 2019

Thanks again! 💚

@s-pace s-pace deleted the feat/search branch September 6, 2019 05:50
@s-pace
Copy link
Contributor Author

s-pace commented Sep 6, 2019

@f3ltron I will make it more clear next time. Thank you :)

@s-pace
Copy link
Contributor Author

s-pace commented Sep 7, 2019

ETA when it will be deployed ?

@flozero
Copy link
Collaborator

flozero commented Sep 7, 2019

i think next week @s-pace

@s-pace
Copy link
Contributor Author

s-pace commented Sep 9, 2019

Thanks @f3ltron 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flozero flozero flozero approved these changes

Assignees

@sarahdayan sarahdayan

Labels
complexity: easy Easy complexity status: core team assigned Core team member assigned topic: docs Used when working with docs type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-pace @flozero @vue-bot @sarahdayan