fix($theme-default): remove error logs for nested sidebar groups

[KieranHunt]

This arbitrarily logged out when nesting was greater than 3.

07:58:13.598 [vuepress] detected a too deep nested sidebar group. 2 2.258cb917.js:1:3364

#2190

Summary

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

N/A

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

N/A

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Opened an issue here: #2190

[KieranHunt]

Added @ulivz, they seem to be the author of the original change here: 01dd45b

[kefranabg]

Hi @KieranHunt I think this is because initially, VuePress was not supporting nested sidebar items indentation if it was higher than 3. But it supposed to be fixed with #1973.

Could you confirm the indentation is correct when nesting is more than 3.

[kefranabg]

Also could you fix parts of the docs saying the maximum is 3?

[KieranHunt]

Could you confirm the indentation is correct when nesting is more than 3.

Set up a toy project

.
├── .git
│ <git things>
├── .vuepress
│   └── config.js
├── 1
│   └── 2
│       └── 3
│           └── 4
│               └── 5
│                   └── README.md
└── README.md

config.js

module.exports = {
  themeConfig: {
    sidebar: [
      '/',
      {
        "title": '1',
        "children": [
          {
            title: '2',
            children: [
              {
                title: '3',
                children: [
                  {
                    title: '4',
                    children: [
                      {
                        title: '5',
                        path: '/1/2/3/4/5/'
                      }
                    ]
                  }
                ]
              }
            ]
          }
        ]
      }
    ]
  }
}

Get a bunch of errors in my console:

16:30:37.368 [vuepress] detected a too deep nested sidebar group. index.js:226

Here's a very tiny gif of it working:

[KieranHunt]

Will hunt around and try find the bits of the docs that refer to 3.

[haoranpb]

The warning about the nested sidebar group is at the bottom of sidebar-groups section.

TIP

Nested sidebar group beta is also supported, but the nesting depth should be less than 3, otherwise the console will receive a warning.

[KieranHunt]

Thanks @ludanxer!

Just checking in to say I haven't forgotten about this PR. Have just been super busy.

[meteorlxy]

I'm going to merge this PR first, and remove the warning in docs in another commit