fix($theme-default): navbar dropdown issue (fix #2349) #2339
Conversation
Mister-Hope
changed the title
|
Sorry for the last fix, I was busy writing my undergraduate thesis last week. @newsbielt703 And this fix really takes me hours to have a simple and correct fix. Since it is not a small bug, you can release 1.4.2 with this fix after review and test it. Besides, if you can review the darkmode I provided, you can also release 1.5.0, |
Mister-Hope
changed the title
|
为啥我升级到1.4.1还是不行呢 |
Vupress team members all have their own works to do, so no one is reviewing this PR, this PR is the fix but it's not merged or published. @meteorlxy @newsbielt703 Could you spend some time review this PR? |
| @@ -75,13 +76,18 @@ export default { | |||
| }, | |||
|
|
|||
| props: { | |||
| inSidebar: { | |||
There was a problem hiding this comment.
It'll only display in sidebar if the device is mobile, so it seems that you only need one of them (inSidebar or isMobile).
| @@ -2,12 +2,13 @@ | |||
| <div | |||
| class="dropdown-wrapper" | |||
| :class="{ open }" | |||
| @focusout="close(true)" | |||
There was a problem hiding this comment.
The close method will only really close when the arg is false or the device is mobile, and it will never happen here.
| mounted () { | ||
| this.isMobile = 'ontouchstart' in document.documentElement | ||
| }, | ||
|
|
||
| methods: { |
There was a problem hiding this comment.
The methods isn't intuitive. The close won't really close, and what isButton? I believe it's here to detect whether users use keyboard to click the button, right?
|
I've make some improvement, see #2365. Welcome to review. |
Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
You have tested in the following browsers: (Providing a detailed version will be better.)