fix: index file judgement bug (#306) #308
Conversation
| @@ -236,7 +236,7 @@ async function genComponentRegistrationFile ({ sourceDir }) { | |||
| return `import Vue from 'vue'\n` + components.map(genImport).join('\n') | |||
| } | |||
|
|
|||
| const indexRE = /\b(index|readme)\.md$/i | |||
| const indexRE = /(?<=(^|\/))(index|readme)\.md$/i | |||
| const extRE = /\.(vue|md)$/ | |||
There was a problem hiding this comment.
lookbehind is good, how about /(^|\/)(index|readme)\.md$/i? it's same for this case.
There was a problem hiding this comment.
It's not the same. \b will not include the word boundary itself. But /(^|\/)(index|readme)\.md$/i will include the begining /
There was a problem hiding this comment.
I meant /(^|\/)(index|readme)\.md$/i ...
There was a problem hiding this comment.
I meant /(^|\/)(index|readme)\.md$/i too... /(^|\/)(index|readme)\.md$/i has different behavior
There was a problem hiding this comment.
Well, in other words, \b and (?<=(^|\/)) won't include the begining /, but (^|\/) will.
For instance:
If the path is 'config/README.md':
/\b(index|readme)\.md$/i=> 'README.md'/(?<=(^|\/))(index|readme)\.md$/i=> 'README.md'/(^|\/)(index|readme)\.md$/i=> '/README.md'
There was a problem hiding this comment.
Well, thanks for the explanation. I thought that the indexRE is only used to test, after double confirm, I find it's also used to replace so this is not the same. cool!
|
Alternative code: const indexRE = /(^|\/)(index|readme)\.md$/i
// ...
// README.md -> /
// foo/README.md -> /foo/
const fileReplace = file.replace(indexRE, '')
return '/' + ( fileReplace === '' ? '' : fileReplace + '/') |
#306