Extends the support of absolute paths as theme dirs towards plugins #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #942, the
loadTheme
documentation (@vuepress/core/lib/prepare/loadTheme.js
) already mentions support of absolute path as a theme directory (even as top priority for resolving):Support of this is also already working for layouts, global components and templates (these were especially tested by me and are working in a production environment for us).
However, support of the plugin api is missing as of now. This pull request adds support of this feature for absolute paths, getting all three options to include a theme in line again.
What kind of change does this PR introduce? (check at least one)
I am unsure if the source documentation can be seen as a statement of intended functional coverage in this case or not.
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes: