feat(typings): adapt to the new Vue typings #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: It is no longer compatible with the old Vue typings
|
@ktsn cool! There's also a stale PR for vue-router: vuejs/vue-router#1204 would you mind reviewing it? |
|
@yyx990803 Ah, I actually also created a PR for vue-router vuejs/vue-router#1685. Forgot to send ping to you 😄 |
|
Ah nice :D |
|
Ping @ktsn would you like to resolve the conflict and change vue repository to dev branch in vuejs org? Thanks! |
|
Done! |
HerringtonDarkholme
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this until vuejs/vue#6391 is merged
I'll update the deps in package.json when vuejs/vue#6391 is merged and released.
close #658