Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action before and after subscribers #1115

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Action before and after subscribers #1115

merged 5 commits into from
Jan 4, 2019

Commits on Jan 3, 2018

  1. allow action subscribers to specify before/after hooks (vuejs#1098) 

    Action subscribers are called before the action by default. This allows them to specify before and after subscribers where the after subscriber is called when the action resolves
    Wael Al-Sallami committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    cdba92e View commit details
    Browse the repository at this point in the history

  2. add test cases for the new before/after action subscribers (vuejs#1098) 

    make sure that the before subscriber is called before the action, while the after subscriber is called after it resolves
    Wael Al-Sallami committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    571fad9 View commit details
    Browse the repository at this point in the history

  3. Replace Promise initialization with shorter form (vuejs#1098)

    Wael Al-Sallami committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    5caff60 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into action-sub-waiting

    Wael Al-Sallami committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    7819a8a View commit details
    Browse the repository at this point in the history

  5. Update subscribeAction type declaration and add type tests (vuejs#1098) 

    Generalize subscribeAction's type declaration to accept both a function or an object and add type tests for that
    Wael Al-Sallami committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d80a16f View commit details
    Browse the repository at this point in the history