Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add key to v-for #1369

Merged
merged 1 commit into from
Sep 1, 2018
Merged

fix: Add key to v-for #1369

merged 1 commit into from
Sep 1, 2018

Conversation

keng0o
Copy link
Contributor

@keng0o keng0o commented Aug 7, 2018

Updates:

  • Add key to v-for

@ktsn ktsn merged commit a9bd047 into vuejs:dev Sep 1, 2018
zlv2s
zlv2s reviewed May 24, 2019
View reviewed changes
examples/shopping-cart/components/ShoppingCart.vue
<li v-for="product in products">
<li
v-for="product in products"
:key="product.id">
Copy link

@zlv2s zlv2s May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm new to Vue, here the product seems to have no id property, i'm not sure if i'm correct or wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlv2s zlv2s zlv2s left review comments

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keng0o @ktsn @zlv2s