-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esm-browser build to dist #1401
Conversation
This would be useful to me. I'm already using Vue's esm-browser build and waiting for plugins to catch up. |
Friendly ping on this PR. |
@@ -61,6 +67,10 @@ function genConfig (opts) { | |||
})) | |||
} | |||
|
|||
if (opts.transpile !== false) { | |||
config.input.plugins.push(buble()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no ;
anywhere else ;)
@TimvdLippe nice! I wanted same thing too. Now that Vue build will ship ES modules it only makes sense we have same for Does your change also build minified and uglified version? |
@@ -33,6 +33,13 @@ const configs = { | |||
input: resolve('src/index.esm.js'), | |||
file: resolve('dist/vuex.esm.js'), | |||
format: 'es' | |||
}, | |||
'esm-browser': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about minified version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it already minify because of env: 'production'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does, but check the actual output in the .min file
@zigomir @yyx990803 Is it time to merge this? |
Closing as this landed in #1533 |
This PR is the complement of vuejs/vue#7110 which is already being distributed on NPM for Vue. I have personally ran the build and imported in my project and I can confirm all references to
process
have been removed and that the code is not transpiled.Fixes #1247