Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add devtools to StoreOptions interface #1478

Closed
wants to merge 1 commit into from

Conversation

haversnail
Copy link
Contributor

Updates StoreOptions type to include the devtools option, resolving TypeScript error when option is included in store constructor.

@haversnail haversnail changed the title Add devtools to store options type Fix: add devtools to StoreOptions interface Jan 2, 2019
@kazupon
Copy link
Member

kazupon commented Jan 30, 2019

/ping @ktsn

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haversnail Thank you for adding the property. Can we add a test code for it?

@Midnighter
Copy link

Coming with an outside perspective: Someone creates a type annotation for you which allows using a publicly documented option on the store with typescript. 5 months later this is still not possible. I fail to see how a test here (whatever that should look like) can trump bringing this into the project.

@kiaking
Copy link
Member

kiaking commented Apr 20, 2020

@ktsn We still want this right? If so, I can take this over.

@kiaking kiaking added the types Related to typings only label Apr 21, 2020
ktsn pushed a commit that referenced this pull request Apr 23, 2020
Add `devtools` to store options type

test: add test case for devtools type
@ktsn
Copy link
Member

ktsn commented Apr 23, 2020

Added a test case and merged in 38c11dc
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Related to typings only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants