Fixed issue#1507 : Memory leak happening while using registerModule/u… #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
requested changes
Mar 7, 2019
…e only one argument.
ktsn
reviewed
Mar 19, 2019
|
Can you please merge it? |
ktsn
approved these changes
Mar 25, 2019
This was referenced May 15, 2019
Closed
This was referenced Aug 29, 2019
This was referenced Nov 18, 2019
This was referenced Jan 21, 2020
This was referenced Mar 1, 2020
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
* Fixed issue#1507 : Memory leak happening while using registerModule/unregisterModule. * Adding comment for leak description. Simplyfy partial function to take only one argument. * Removed oldVm.computed = null. This statement is not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1507
Closure function was fixed with helper function partial which doesn't retain oldVm in environment.