Add support for namespace functions in mapXXX helpers #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hufeng
reviewed
Jul 17, 2019
| @@ -11,7 +11,13 @@ export const mapState = normalizeNamespace((namespace, states) => { | |||
| let state = this.$store.state | |||
| let getters = this.$store.getters | |||
| if (namespace) { | |||
| const module = getModuleByNamespace(this.$store, 'mapState', namespace) | |||
| if (typeof namespace === 'function') { | |||
| namespace = namespace.call(this, this) | |||
There was a problem hiding this comment.
Because the component may be loaded multiple times, the namespace of the subsequent component is always the result of the first execution, so the code cannot override namespace = namespace.call(this, this), we can use the local variable let ns = namespace.call(this, this)
|
Closing as we have released our internal solution to this as a separate package: https://www.npmjs.com/package/@urbn/vuex-helpers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stab at adding the functionality requested by #863.
I also noticed that there was another attempt at this in #924, but the diff seems to be beyond the scope of just the change.
Unit tests have been added, but no changes have yet been made to TypeScript types or documentation, etc.