Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow action subscribers to catch rejections. #1740

Merged
merged 9 commits into from
May 8, 2020

Conversation

jmplahitko
Copy link
Contributor

@kiaking - Thanks for the direction. This is the pull request to replace #1531

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It's looking good to me. But, there's still dist folder in the commit 😓 Could you please remove it 🙏

@cuebit
Copy link
Member

cuebit commented May 1, 2020

Sorry @jmplahitko, I don't think we've been very clear in what we're asking of you, and I apologise for that.

When members ask to have dist removed from a commit, generally it means avoiding adding any files modified in the dist directory to the commit.

If it makes things easier, 1) take the dist directory from dev and throw it back in, 2) commit dist, and 3) run tests again but this time don't include any modifications in dist.

Hope that makes a little more sense.

@jmplahitko
Copy link
Contributor Author

@kiaking - Not your fault, I misunderstood. Hopefully that last commit gets us there. Thanks.

@cuebit cuebit requested a review from kiaking May 5, 2020 00:28
src/store.js Outdated Show resolved Hide resolved
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks so much for the work. We know we need to fix the test because we've just switched to using Jest, but I'll fix that right after merging this one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants