Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include logger plugin to the core export #1783

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jun 24, 2020

This PR add logger plugin to the core export to be able to support ESM build for the logger plugin. Issue was mentioned at vitejs/vite#334.

This is for Vuex 3, so I'm keeping the individual bundle as is to avoid braking change. For Vuex 4, I'm planning to remove the logger bundle entirely.

Planning to follow up the PR with documentation update as well for the next release.

@kiaking kiaking added the enhancement New feature or request label Jun 24, 2020
@kiaking kiaking requested a review from ktsn June 24, 2020 08:33
@kiaking kiaking self-assigned this Jun 24, 2020
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants