-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade eslint and fix lint and type errors #1600
Conversation
import { getDirname, path } from 'vuepress/utils' | ||
|
||
const __dirname = getDirname(import.meta.url) | ||
const DIRNAME = getDirname(import.meta.url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, I think the original one is fine, and I have seen other repos doing this.
Are there some rules that disallow this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all fine. Just don't want to add complicated @typescript-eslint/naming-convention
override 😮💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mister-Hope Reverted. It should have been supported in eslint-config-vuepress@5.1.4
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description