Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade eslint and fix lint and type errors #1600

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Conversation

meteorlxy
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Documentation update
  • Other

Description

  • Upgraded eslint to v9
  • Fixed lint errors
  • Fixed type errors

@meteorlxy meteorlxy changed the title fix: upgrade eslint and fix lint and type errors refactor: upgrade eslint and fix lint and type errors Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 10414550633

Details

  • 40 of 174 (22.99%) changed or added relevant lines in 64 files are covered.
  • 10 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.05%) to 38.561%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bundler-vite/src/build/renderPage.ts 0 1 0.0%
packages/bundler-vite/src/build/renderPagePrefetchLinks.ts 0 1 0.0%
packages/bundler-vite/src/build/renderPagePreloadLinks.ts 0 1 0.0%
packages/bundler-webpack/src/build/renderPagePrefetchLinks.ts 0 1 0.0%
packages/bundler-webpack/src/build/renderPagePreloadLinks.ts 0 1 0.0%
packages/bundler-webpack/src/config/createBaseConfig.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleEntry.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleModuleAssets.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleModuleJs.ts 0 1 0.0%
packages/bundler-webpack/src/config/handleModuleTs.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/client/src/setupGlobalComponents.ts 1 0.0%
packages/client/src/app.ts 1 0.0%
packages/bundler-webpack/src/build/resolvePageClientFilesMeta.ts 1 0.0%
packages/client/src/router/resolveRoutePath.ts 1 0.0%
packages/bundler-webpack/src/config/handleModuleTs.ts 1 0.0%
packages/client/src/components/RouteLink.ts 1 0.0%
packages/cli/src/cli.ts 2 9.52%
packages/bundler-webpack/src/config/handlePluginDefine.ts 2 0.0%
Totals Coverage Status
Change from base Build 10398742588: -0.05%
Covered Lines: 632
Relevant Lines: 1668

💛 - Coveralls

import { getDirname, path } from 'vuepress/utils'

const __dirname = getDirname(import.meta.url)
const DIRNAME = getDirname(import.meta.url)
Copy link
Member

@Mister-Hope Mister-Hope Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, I think the original one is fine, and I have seen other repos doing this.

Are there some rules that disallow this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all fine. Just don't want to add complicated @typescript-eslint/naming-convention override 😮‍💨

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mister-Hope Reverted. It should have been supported in eslint-config-vuepress@5.1.4

@meteorlxy meteorlxy marked this pull request as ready for review August 16, 2024 04:05
@meteorlxy meteorlxy merged commit 3ca0230 into main Aug 16, 2024
30 checks passed
@meteorlxy meteorlxy deleted the upgrade-eslint branch August 16, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants