-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vuepress): add create-helper (close #1) #15
Conversation
Pull Request Test Coverage Report for Build 7664516576
💛 - Coveralls |
These might be better as a future enhancement. |
typescript is not actually needed bro, all ts files are handled by esbuild, and editors like vscode can use built-in ts lib to parse the project. since we are not generating git project, I remove the .gitignore logic. you can try |
For typescript I was referring to adding an option to generate the vuepress site with *.ts files instead of *.js. This would be similar to the option in the the create vue template using |
cc @nruffing Could you please check this again? |
bundler, | ||
}: CreatePackageJsonOptions): Promise<void> => { | ||
const packageJsonPath = join(targetDir, 'package.json') | ||
// TODO: Update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make use of npm view vuepress@next version
command to get the latest version. ref code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am negative towards it, a lot of area in China can counter timeout at this stage.
E.g.: yarn is using a different config, and users can still meet timeout with the default registry even if they set mirror registry in yarn.
Also, we are likely to ship breaking changes in the comming rc versions, so fixing it to a exact version should be the best choice at this momenet.
However we can improve this later once vuepress2 reach stable.
This could be am improvement, but I don't think this is needed. Here are reasons:
So under this point of view, rare people would benefit from this config, so I think this is not needed. |
No description provided.