Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BottomNavigation, AppHeader - center items and add mobile menu #185

Merged
merged 5 commits into from
Mar 22, 2022
Merged

fix: BottomNavigation, AppHeader - center items and add mobile menu #185

merged 5 commits into from
Mar 22, 2022

Conversation

AdamPawlinski
Copy link
Contributor

Description

Added mobile menu in AppHeader to be opened on click in Bottom Navigation.
BottomNavigation items centered.

Related Issue

#184

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

vendure_mobile_menu

Types of changes

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Baroshem
Baroshem reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small recommendations to include. Overall, very good!

packages/theme/components/BottomNavigation.vue Show resolved Hide resolved
packages/theme/components/BottomNavigation.vue Outdated Show resolved Hide resolved
packages/theme/components/BottomNavigation.vue Outdated Show resolved Hide resolved
packages/theme/components/AppHeader.vue Outdated Show resolved Hide resolved
@Baroshem Baroshem merged commit d993d21 into develop Mar 22, 2022
@ashishkpaul
Copy link

ashishkpaul commented Nov 3, 2022 •
edited
Loading

Menu navigation working through git clone repo but not working with cli installation
as well as user account page (http://example.com/my-account) hang when repo clone through git but not hanging with cli installation.
please also read vuestorefront/vue-storefront#6820 (comment)

@ashishkpaul ashishkpaul mentioned this pull request Nov 3, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem Baroshem approved these changes

Assignees

@AdamPawlinski AdamPawlinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamPawlinski @ashishkpaul @Baroshem