Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

Add missing parameters to processor adapters #218

Merged

Conversation

jahvi
Copy link
Contributor

@jahvi jahvi commented Apr 17, 2019

The GraphQL endpoint is not setting the required req and res parameters in the processor adapter so queries to the products query are throwing the following error:

Entering ProductProcessor::process
Taxes will be calculated for GB  false
Elasticsearch INFO: 2019-04-17T18:25:22Z
  Adding connection to http://localhost:9200/

Elasticsearch DEBUG: 2019-04-17T18:25:22Z
  starting request {
    "method": "POST",
    "path": "/vue_storefront_magento_1/taxrule/_search",
    "body": {},
    "query": {}
  }


Elasticsearch DEBUG: 2019-04-17T18:25:22Z
  Request complete

TypeError: Cannot read property 'query' of undefined
    at ProductProcessor.<anonymous> (/Users/jahvi/Repositories/vue-storefront-api/src/processor/product.js:33:21)

@jahvi jahvi force-pushed the fix/missing-processor-params branch from 2ac653c to a344e11 Compare April 17, 2019 20:23
@jahvi jahvi force-pushed the fix/missing-processor-params branch from a344e11 to 6eb9427 Compare April 17, 2019 20:24
@lukeromanowicz lukeromanowicz self-requested a review April 17, 2019 21:55
@lukeromanowicz lukeromanowicz merged commit 8a140b3 into vuestorefront:develop Apr 20, 2019
lukeromanowicz added a commit that referenced this pull request Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants