This repository has been archived by the owner on May 28, 2023. It is now read-only.
introduce orderNumber to order creation endpoint #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As its common to show customers an OrderNumber which is in no relation to the ID used for the Order Entity, it makes sense to introduce this in a platform agnostic way.
Magento for example uses the increment_id for the order number. It will likely be named different for other systems.
To prevent BC breaks in the future, the name should be carefully thought out.
Currently the recent solution for the MyOrder Page is relying on the existence of increment_id, which may not exist for other Systems.
related issue:
vuestorefront/vue-storefront#2743
Follow Up changes:
I left the magentoOrderId unchanged, as Iam not sure about its usage and did not want to provoke a BC break.