-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove categories with unknown url_path
from breadcrumbs
#4488
Remove categories with unknown url_path
from breadcrumbs
#4488
Conversation
In already 4 instances of Vue Storefront 1 with Magento 1, I've encountered the following issue: When categories are loaded into the breadcrumbs, they include the Magento Root Category (often with a name like **Default Category**). But because this Root Category serves a special purpose, the URL path is always empty. This fix simply checks whether the URL path is `undefined` and if so, it skips that category. Because the breadcrumbs are supposed to only contain categories with the URL path set.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/vue-storefront/8wgg8ub3m |
Hey @jissereitsma wdyt about adding changes to
after:
format |
Can you please rebase to branch |
@gibkigonzo This should be done now. |
In already 4 instances of Vue Storefront 1 with Magento 1, I've encountered the following issue: When categories are loaded into the breadcrumbs, they include the Magento Root Category (often with a name like Default Category). But because this Root Category serves a special purpose, the URL path is always empty. This fix simply checks whether the URL path is
undefined
and if so, it skips that category. Because the breadcrumbs are supposed to only contain categories with the URL path set.