-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ESLint 9.x #93
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
import vuetify from 'eslint-config-vuetify'
{
...
rules: {
...vuetify.rules,
// Other rules
}
...
} |
// .eslintrc.js @kieuminhcanh meant to have dependency support for ESLint 9.x; still get npm ERR! While resolving: rehearsal-room-web@1.0.3
npm ERR! Found: eslint@9.0.0
npm ERR! node_modules/eslint
npm ERR! dev eslint@"^9.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^8.0.0" from eslint-plugin-vuetify@2.4.0
npm ERR! node_modules/eslint-plugin-vuetify
npm ERR! dev eslint-plugin-vuetify@"^2.4.0" from the root project |
@kieuminhcanh Can you please reopen? This request was for eslint-plugin-vuetify not eslint-config-vuetify. |
@1Luc1 I tried updating this repo to 9 but all the tests fail for not being flat file config. I will take a look to see if I can get them updated tomorrow and make a PR |
Hi, are there any updates on this? |
Tried brute force to use the plugin in flat config file.
elicited a
This means I should I wait for an official release that supports ESlint 9.0? |
I found you can use this guide for compatibility https://eslint.org/docs/latest/use/configure/migration-guide#using-eslintrc-configs-in-flat-config import { FlatCompat } from "@eslint/eslintrc"
import pluginVue from "eslint-plugin-vue"
import pluginVuetify from "eslint-plugin-vuetify"
const compat = new FlatCompat({
config: pluginVuetify.configs.recommended,
})
export default [
...pluginVue.configs["flat/essential"],
...pluginVue.configs["flat/recommended"],
...pluginVue.configs["flat/strongly-recommended"],
...compat.extends("plugin:vue/base", "plugin:vuetify/base"),
] |
Yes, thanks! This helps but not solve the problem that a simple |
Hi, is there any update on this? Eslint 9.8 is already released and we cannot upgrade without using --force. |
Is this going anywhere? |
I submitted a PR that fixes this and makes |
To use my fork until they merge my PR into the official npm package: // eslint.config.js
import pluginVuetify from "../eslint-plugin-vuetify/src/configs/flat/base.js" // or whatever the path to your submodule is.
// To use the `recommended` configuration (including extra rules for the grid system) replace `base.js` with `recommended.js`
export default [
pluginVuetify
] Remember that my code will need to be available to your CI/CD system. So keep that in mind when cloning your repo. Make sure that it's included in your git repo. |
I would like to see the fixed merged, just a friendly reminder. Thanks! |
Please resolve this as soon as possible. Thanks! @KaelWD |
I submitted a pull request that fixes this two months ago. It still hasn't been merged |
Two PR exists:
|
Bump. |
ESLint v9.0.0 is released !
It would be awesome to have official ESLint 9 support.
https://eslint.org/blog/2024/04/eslint-v9.0.0-released/
The text was updated successfully, but these errors were encountered: