fix(click-outside): correctly remove shadow DOM event listeners (#20273)

fixes #19616
vuetifyjs · Aug 3, 2024 · 9b02b0d · 9b02b0d
1 parent 40f7197
commit 9b02b0d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/vuetify/src/directives/click-outside/__tests__/click-outside-shadow-dom.spec.ts b/packages/vuetify/src/directives/click-outside/__tests__/click-outside-shadow-dom.spec.ts
@@ -63,15 +63,15 @@ describe('click-outside.js within the Shadow DOM', () => {
     const { outsideClickHandler, shadowEl, binding } = bootstrap()
     expect(window.document.addEventListener).toHaveBeenCalledWith('click', outsideClickHandler, true)
 
-    ClickOutside.unmounted(shadowEl, binding)
+    ClickOutside.beforeUnmount(shadowEl, binding)
     expect(window.document.removeEventListener).toHaveBeenCalledWith('click', outsideClickHandler, true)
   })
 
   it('should register and unregister handler within the shadow DOM', () => {
     const { shadowClickHandler, shadowRoot, shadowEl, binding } = bootstrap()
     expect(shadowRoot.addEventListener).toHaveBeenCalledWith('click', shadowClickHandler, true)
 
-    ClickOutside.unmounted(shadowEl, binding)
+    ClickOutside.beforeUnmount(shadowEl, binding)
     expect(shadowRoot.removeEventListener).toHaveBeenCalledWith('click', shadowClickHandler, true)
   })
 

diff --git a/packages/vuetify/src/directives/click-outside/__tests__/click-outside.spec.ts b/packages/vuetify/src/directives/click-outside/__tests__/click-outside.spec.ts
@@ -44,7 +44,7 @@ describe('v-click-outside', () => {
     const { clickHandler, el, binding } = bootstrap()
     expect(window.document.addEventListener).toHaveBeenCalledWith('click', clickHandler, true)
 
-    ClickOutside.unmounted(el, binding)
+    ClickOutside.beforeUnmount(el, binding)
     expect(window.document.removeEventListener).toHaveBeenCalledWith('click', clickHandler, true)
   })
 

diff --git a/packages/vuetify/src/directives/click-outside/index.ts b/packages/vuetify/src/directives/click-outside/index.ts
@@ -102,7 +102,7 @@ export const ClickOutside = {
     }
   },
 
-  unmounted (el: HTMLElement, binding: ClickOutsideDirectiveBinding) {
+  beforeUnmount (el: HTMLElement, binding: ClickOutsideDirectiveBinding) {
     if (!el._clickOutside) return
 
     handleShadow(el, (app: HTMLElement) => {