Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] VBtn variant outlined add sass variables for at least border-width #16786

Closed
ricardovanlaarhoven opened this issue Feb 27, 2023 · 0 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307, Enterprise-CMCS/cmcs-eregulations#1313 or Enterprise-CMCS/cmcs-eregulations#1315 · May be fixed by Shuunen/ging#200
Closed

[Feature Request] VBtn variant outlined add sass variables for at least border-width #16786

ricardovanlaarhoven opened this issue Feb 27, 2023 · 0 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307, Enterprise-CMCS/cmcs-eregulations#1313 or Enterprise-CMCS/cmcs-eregulations#1315 · May be fixed by Shuunen/ging#200
Assignees
@johnleider
Labels
framework Issues and Feature Requests that have needs framework-wide. T: enhancement Functionality that enhances existing features
Milestone
v3.6.0 (Nebula)

Comments

@ricardovanlaarhoven
Copy link
Contributor

Problem to solve

Make it possible to change the width of an outlined button with props, defaults or sass variables

$button-border, $button-border-width, $button-border-thin-width don't seem to do the trick, it's now only available with an override

Proposed solution

vuetify/packages/vuetify/src/styles/tools/_variant.sass

Line 36 in 9e3003f

border: thin solid currentColor

Use sass variables in this file
@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: VBtn C: VChip labels Apr 28, 2023
@KaelWD KaelWD added this to the v3.x.x milestone Apr 28, 2023
@KaelWD KaelWD mentioned this issue Apr 28, 2023
Closed
@johnleider johnleider modified the milestones: v3.x.x, v3.6.0 (Nebula) Jan 26, 2024
@johnleider johnleider self-assigned this Apr 15, 2024
@johnleider johnleider added framework Issues and Feature Requests that have needs framework-wide. and removed C: VBtn C: VChip labels Apr 15, 2024
johnleider added a commit that referenced this issue Apr 15, 2024
@johnleider
feat(variant): add configurable $border-width-root
2abb221 
resolves #16786
@Shuunen Shuunen mentioned this issue May 21, 2024
Open
@aniketmaurya aniketmaurya mentioned this issue May 22, 2024
Closed
@brittag brittag mentioned this issue May 22, 2024
Merged
@aniketmaurya aniketmaurya mentioned this issue May 23, 2024
Closed
@brittag brittag mentioned this issue May 24, 2024
Merged
@aniketmaurya aniketmaurya mentioned this issue May 25, 2024
Closed
@brittag brittag mentioned this issue May 28, 2024
Merged
This was referenced May 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
framework Issues and Feature Requests that have needs framework-wide. T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v3.6.0 (Nebula)
3 participants
@ricardovanlaarhoven @johnleider @KaelWD