Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] VExpandTransition group #19210

Closed
TimoCuijpers opened this issue Feb 12, 2024 · 4 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Closed

[Feature Request] VExpandTransition group #19210

TimoCuijpers opened this issue Feb 12, 2024 · 4 comments · Fixed by Enterprise-CMCS/cmcs-eregulations#1307 · May be fixed by Shuunen/ging#200
Labels
C: Transitions T: enhancement Functionality that enhances existing features

Comments

@TimoCuijpers
Copy link

Problem to solve

A v-expand-transition doesn't have the prop "group".
I want to add the transition to multiple v-cols for example but this isn't possible now.

Proposed solution

Add the group prop to the v-expand-transition like all the other transitions

@websitevirtuoso
Copy link
Contributor

Could you provide use case? provide current implementation and extected behavious with "group" option?

Based on:
https://vuejs.org/guide/built-ins/transition
https://vuejs.org/guide/built-ins/transition-group

Thanks

@ascott18
Copy link
Contributor

ascott18 commented Mar 5, 2024

I would love to see the same - the use case is very simple. I have a list of elements created by a v-for. I would like elements that are removed from the iteration animate out with a collapse animation, and elements added by the iteration to animate in with an expand animation.

Simple code that I'd like to have work:

<v-expand-transition group>
  <div v-for="item in myItems" :key="item.id">
    {{ item.text }}
  </div>
</v-expand-transition>

Instead, the following warning is present and the UI doesn't work because v-expand-transition doesn't support group:

[Vue warn]: <transition> can only be used on a single element or component. Use <transition-group> for lists. 
  at <BaseTransition onBeforeEnter=fn<onBeforeEnter> onEnter=fn onAfterEnter=fn<resetStyles>  ... > 
  at <Transition name="expand-transition" css=true onBeforeEnter=fn<onBeforeEnter>  ... > 
  at <ExpandTransition> 

@websitevirtuoso
Copy link
Contributor

Yes, I know that it can be implemented. but we already have it in vue and using documentation you can implement group transition.
I don't see any sense, to copy paste this from vue to vuetify.

@ascott18
Copy link
Contributor

ascott18 commented Mar 6, 2024

we already have it in vue

Could you show me where this code already exists in Vue?

using documentation you can implement

Yes, by using documentation you can implement almost anything. I'm not sure that's a strong argument for deciding whether to implement something in a framework like Vuetify, since that logic taken to its extremes means that Vuetify should not exist at all since everything in Vuetify is implemented in accordance with Vue's documentation and APIs.

I don't see any sense, to copy paste this from vue to vuetify.

90% of the work for this already exists in Vuetify, whereas I'm not sure any of it already exists in Vue. But I'd love to be corrected here if this does already exist in Vue!

ascott18 added a commit to ascott18/vuetify that referenced this issue Mar 6, 2024
ascott18 added a commit to ascott18/vuetify that referenced this issue Mar 6, 2024
@KaelWD KaelWD added T: enhancement Functionality that enhances existing features C: Transitions labels Mar 7, 2024
@KaelWD KaelWD added this to the v3.6.0 (Nebula) milestone Mar 7, 2024
@github-actions github-actions bot removed the S: triage label Mar 7, 2024
KaelWD pushed a commit that referenced this issue Mar 7, 2024
@github-actions github-actions bot closed this as completed Mar 7, 2024
VIXI0 pushed a commit to VIXI0/vuetify that referenced this issue Mar 13, 2024
VIXI0 pushed a commit to VIXI0/vuetify that referenced this issue Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment