Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.5.7] v-date-picker with dayjs crashes when using range selector #19330

Closed
Ribeiro-Tiago opened this issue Mar 4, 2024 · 1 comment · Fixed by #19336
Closed

Comments

@Ribeiro-Tiago
Copy link

Ribeiro-Tiago commented Mar 4, 2024

Environment

Vuetify Version: 3.5.7
Vue Version: 3.4.21
Browsers: Chrome 121.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

use date-io/dayjs adapter

import { createVuetify } from 'vuetify'
import DayJsAdapter from '@date-io/dayjs'

export const vuetify = createVuetify({
  date: { adapter: DayJsAdapter },
})

configure date picker with multiple=range

<v-date-picker color="primary" multiple="range"></v-date-picker>

try to select a range

Expected Behavior

when using dayjs as a date adapter for the vuetify instance, expected when choosing the second date in the range, the range would be selected

Actual Behavior

selecting the second date in the range causes the window to hang which leads to a OOM crash

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

running locally with devtools open, the browser debugger gets triggered instead of crashing, Paused before potential out-of-memory crash

Screenshot 2024-03-04 at 11 14 31

@agentschmitt
Copy link

the same issue occurs with other dateAdapters e.g. date-fns

Reproduction Link
date-fns sample

johnleider pushed a commit that referenced this issue Mar 5, 2024
fixes #19330

Co-authored-by: Son Tran <stt@cct-technology.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants