Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.6.5] The rail attribute of the VNavigationDrawer does not take effect when the encapsulated component is introduced. #19800

Closed
AndyBeat opened this issue May 13, 2024 · 6 comments
Assignees
Labels
C: VNavigationDrawer VNavigationDrawer T: bug Functionality that does not work as intended/expected

Comments

@AndyBeat
Copy link

Environment

Vuetify Version: 3.6.5
Last working version: 3.5.18
Vue Version: 3.4.27
Browsers: Chrome 124.0.0.0
OS: Windows 10

Steps to reproduce

Click the list icon on the toolbar

Expected Behavior

The left navigation can be retracted

Actual Behavior

No change to left navigation

Reproduction Link

https://codesandbox.io/p/github/AndyBeat/vuetify-navigation-test/master?file=%2Fsrc%2FApp.vue%3A17%2C1

Other comments

The same navigation bar code, the drawer attribute takes effect normally when used externally, but it does not take effect when encapsulated into a separate interface nav-drawer. This problem was also found on the vuetify doc page of the same version.

There is no change after the first click. It shrinks after refreshing. Clicking again cannot restore the original state. After refreshing, it is normal.

1715591046536

@johnleider
Copy link
Member

I really don't understand what you're trying to do and if this is an implementation issue or a bug.

@AndyBeat
Copy link
Author

I think it's a bug. After all, versions before 3.5.18 don't do this. This is a dynamic diagram of the effects of the two versions. Can you understand it?

vuetify 3.6.0:
nav

vuetify 3.4.3:
nav-2

@AndyBeat
Copy link
Author

My English is not very good, I hope you can understand me. See if this screenshot helps you understand

1715611148739

nav-3

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VNavigationDrawer VNavigationDrawer labels May 13, 2024
@KaelWD KaelWD self-assigned this May 13, 2024
@KaelWD
Copy link
Member

KaelWD commented May 13, 2024

@johnleider this is the same problem we were looking at last week with the drawer not hiding on mobile.

@KaelWD KaelWD changed the title [Bug Report][3.6.5][V-navigation-drawer]The drawer attribute of the V-navigation-drawer component does not take effect when the encapsulated component is introduced. [Bug Report][3.6.5] The rail attribute of the VNavigationDrawer does not take effect when the encapsulated component is introduced. May 21, 2024
@johnleider
Copy link
Member

Where we are currently at with the issue:

This watcher isn't firing correctly:

watch(isTemporary, val => !props.permanent && (nextTick(() => isActive.value = !val)))

When an application is resized, the isTemporary change that occurs from mobile.value isn't causing the watcher to fire:

const isTemporary = computed(() => !props.permanent && (mobile.value || props.temporary))

@KaelWD KaelWD added this to the v3.7.0 (Odyssey) milestone Aug 15, 2024
KaelWD added a commit that referenced this issue Aug 15, 2024
@KaelWD
Copy link
Member

KaelWD commented Aug 15, 2024

I couldn't figure out how to fix this, I'm reverting #15229 in 3.7 because suspense is clearly not ready to use yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VNavigationDrawer VNavigationDrawer T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants