Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.6.14] Maximum call stack size exceeded when using elements in default options #20278

Closed
cgodo opened this issue Aug 4, 2024 · 0 comments · Fixed by #20284 · 4 remaining pull requests
Closed

[Bug Report][3.6.14] Maximum call stack size exceeded when using elements in default options #20278

cgodo opened this issue Aug 4, 2024 · 0 comments · Fixed by #20284 · 4 remaining pull requests
Assignees
@KaelWD
Labels
E: defaults Defaults composable T: bug Functionality that does not work as intended/expected
Milestone
v3.7.x

Comments

@cgodo
Copy link
Contributor

cgodo commented Aug 4, 2024

Environment

Vuetify Version: 3.6.14
Vue Version: 3.5.0-alpha.5
Browsers: Chrome 127.0.0.0
OS: Windows 10, Linux

Steps to reproduce

  • Create Vuetify with defaults configuration, setting the attach property of VMenu to a custom element instance.
  • Add a VMenu and open it.

Expected Behavior

The menu opens normally.

Actual Behavior

Maximum call stack size exceeded is thrown and the menu does not open.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

It might be that mergeDeep utility used by the defaults composable is not able to merge objects with circular references.

While a string selector can be used for the attach property of VMenu, it does not work within the Shadow DOM. Document selectors cannot reach shadow elements, so it is necessary to pass an element instance in these cases.
cgodo added a commit to cgodo/vuetify that referenced this issue Aug 6, 2024
@cgodo
fix(helpers): allow to mergeDeep circular references and Nodes
5a38e61 
fixes vuetifyjs#20278
cgodo added a commit to cgodo/vuetify that referenced this issue Aug 6, 2024
@cgodo
fix(helpers): allow to mergeDeep circular references and Nodes
e0d78a1 
fixes vuetifyjs#20278
@cgodo cgodo mentioned this issue Aug 6, 2024
Merged
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected E: defaults Defaults composable labels Aug 16, 2024
@KaelWD KaelWD self-assigned this Aug 16, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Aug 16, 2024
@KaelWD KaelWD mentioned this issue Aug 16, 2024
Open
KaelWD pushed a commit that referenced this issue Aug 27, 2024
@cgodo
fix(helpers): only deep merge plain objects (#20284)
8af59fc 
Co-authored-by: Kael <kaelwd@gmail.com>

fixes #20278
This was referenced Sep 18, 2024
Open
Open
@WontonSam WontonSam mentioned this issue Oct 7, 2024
Open
@aurelienfvre aurelienfvre mentioned this issue Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
E: defaults Defaults composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.7.x
2 participants
@cgodo @KaelWD