Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.7.0] aria-current="page" should be defined on active links in addition to active classes #20399

Closed
paul-thebaud opened this issue Aug 26, 2024 · 0 comments · Fixed by #20413 or con-cis/mc-docu#48 · May be fixed by mygivvara/codex#5 or aurelienfvre/sae401#1
Closed

[Bug Report][3.7.0] aria-current="page" should be defined on active links in addition to active classes #20399

paul-thebaud opened this issue Aug 26, 2024 · 0 comments · Fixed by #20413 or con-cis/mc-docu#48 · May be fixed by mygivvara/codex#5 or aurelienfvre/sae401#1
Labels
a11y Accessibility issue T: bug Functionality that does not work as intended/expected
Milestone
v3.7.x

Comments

@paul-thebaud
Copy link
Contributor

Environment

Vuetify Version: 3.7.0
Vue Version: 3.4.38
Browsers: Chrome 128.0.0.0
OS: Linux x86_64

Steps to reproduce

Create two links inside a project using Vuetify and Vue Router while being on home page:

  • <router-link to="/">Home</router-link>
  • <v-btn to="/">Home</v-btn>

Expected Behavior

Both links should get the aria-current="page" attribute.

Actual Behavior

Only router-link is getting the aria-current="page" attribute.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

I know reproduction does not show the problem because no vue router is defined.
I'm sorry I didn't had the time to setup a real repo.
@vuetifyjs vuetifyjs deleted a comment from Lxx-c Aug 26, 2024
paul-thebaud added a commit to paul-thebaud/vuetify that referenced this issue Sep 2, 2024
@paul-thebaud
fix(a11y): add aria-current="page" attribute to links
daae92a 
closes vuetifyjs#20399
@paul-thebaud paul-thebaud mentioned this issue Sep 2, 2024
Merged
paul-thebaud added a commit to paul-thebaud/vuetify that referenced this issue Sep 2, 2024
@paul-thebaud
fix(a11y): add aria-current="page" attribute to links
b1b3285 
closes vuetifyjs#20399
paul-thebaud added a commit to paul-thebaud/vuetify that referenced this issue Sep 2, 2024
@paul-thebaud
fix(a11y): add aria-current="page" attribute to links
c2a991e 
closes vuetifyjs#20399
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected a11y Accessibility issue labels Sep 3, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Sep 3, 2024
@github-actions github-actions bot removed the S: triage label Sep 3, 2024
KaelWD added a commit that referenced this issue Sep 3, 2024
@paul-thebaud @KaelWD
fix(a11y): add aria-current="page" attribute to links (#20413)
bc647f6 
closes #20399

Co-authored-by: Kael <kaelwd@gmail.com>
@con-cis con-cis mentioned this issue Nov 9, 2024
Merged
@mygivvara mygivvara mentioned this issue Nov 10, 2024
Open
@aurelienfvre aurelienfvre mentioned this issue Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility issue T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.7.x
2 participants
@KaelWD @paul-thebaud