Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.7.3] V-List-Items should not have property "aria-selected" #20666

Closed
kmmerc18 opened this issue Nov 4, 2024 · 1 comment
Closed
Assignees
Labels
a11y Accessibility issue C: VListItem VListItem good first issue A quick-win fix that would be great for new contributors T: bug Functionality that does not work as intended/expected
Milestone

Comments

@kmmerc18
Copy link

kmmerc18 commented Nov 4, 2024

Environment

Vuetify Version: 3.7.3
Last working version: 3.7.2
Vue Version: 3.5.12
Browsers: Chrome 130.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

Run the axe DevTools Chrome extension on the page to view accessibility issues : https://www.deque.com/axe/devtools/chrome-browser-extension/?utm_term=axe%20chrome%20extension&utm_campaign=Search+-+axe+DevTools+Extension+-+Branded&utm_source=adwords&utm_medium=ppc&hsa_src=g&hsa_ad=626089536231&hsa_tgt=kwd-1186988429008&hsa_mt=p&hsa_ver=3&hsa_acc=7854167720&hsa_kw=axe%20chrome%20extension&hsa_grp=142979637051&hsa_cam=17378411167&hsa_net=adwords&gad_source=1&gclid=Cj0KCQiA_qG5BhDTARIsAA0UHSLdeJ9Sqz7AWxRyxMgv0xbuOZUaa288baPX3SoHfQ84FeVmFKc2JvEaAlnmEALw_wcB

Expected Behavior

No issues related to aria-selected should exist

Actual Behavior

Three issues appear under the title "Elements must only use supported attributes"

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

Looks like all v-list-items in the latest version of vuetify have the attribute "aria-selected=false" by default. According to the Deque tool, this attribute should not appear on v-list-items

@MatthewAry MatthewAry added a11y Accessibility issue C: VListItem VListItem T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors and removed S: triage labels Nov 14, 2024
@KaelWD KaelWD self-assigned this Nov 20, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Nov 20, 2024
@KaelWD KaelWD closed this as completed in 72df0b4 Nov 20, 2024
KaelWD added a commit to J-Sek/vuetify that referenced this issue Nov 27, 2024
@gosear
Copy link

gosear commented Dec 6, 2024

PixPin_2024-12-04_15-50-49
PixPin_2024-12-04_15-52-42
But VListItem component still have the "aria-selected" attribute when It in VListGroup activator slot.
Please see this example on the official website.
Did I misunderstand the fix commit ?
@KaelWD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue C: VListItem VListItem good first issue A quick-win fix that would be great for new contributors T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants