-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] v-tooltip does not work when activator is set using the new slot syntax #6440
Comments
They aren't equivalent, |
If I understand things correctly, the latest Vue update made it so |
True, but that's supposed to be for backwards compatibility with existing components. That differentiation won't be available in vue 3, so it's best that we only support the new scoped use with v-slot. I can add a warning if |
also added warning if #activator is used without binding (#6440)
@KaelWD is this something that can be improved in 2.0 or are we forever stuck with this syntax? if so I'll just ignore the warning thrown in |
@KaelWD upgrade 1.5.0 to 1.5.1 have breaking change for those, who used new slot syntax |
I do agree that it's rather verbose, I'll see if there's anything else we can do for future versions.
The warning means it isn't working
No it isn't, it was working correctly in 1.4.x with the 2.6 beta until vue changed how slots work again with the other 2.6.x patches. |
@KaelWD yeah I noticed that about the warning. I think he means that in edit: https://codepen.io/anon/pen/omyjyq?&editable=true&editors=101 this breaks in 1.5.1 |
after upgrade from 1.5.0 to 1.5.1 |
That was a bug, if you set vue to 2.6.1 and vuetify 1.5.0 it works the same as now. You couldn't use |
true, but vue |
It was never intended to work. I can tell the difference between the two if I wanted but that possibility will be removed in vue 3.0 so it's best if those migrating to the new syntax use the one that will keep working. |
Fair enough, I'm all for looking ahead (3.0), but at the same time it might seem odd that Vue itself allows for backwards compat in >= |
Not if you're already using both slots and scopedSlots, I've had to pull some really weird shit to get that to work. The backwards compat is more for old components that aren't updated to use $scopedSlots See vuejs/vue#9421, vuejs/vue#9458 (comment) for more.
|
tragic, guess I'll just have to bite the bullet on this syntax, I guess this issue can be closed? |
Versions and Environment
Vuetify: 1.5.0
Last working version: 1.4.0
Vue: 2.6.4
Browsers: Firefox 67.0, Microsoft Edge, Mozilla Firefox, Google Chrome
OS: Windows 10, Linux
Steps to reproduce
Change the template from
<template slot="activator">
to<template #activator>
.Expected Behavior
Tooltip still appears when activator is hovered.
Actual Behavior
Tooltip does not appear.
Reproduction Link
https://jsfiddle.net/d9qc0n26/1/
The text was updated successfully, but these errors were encountered: