-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vlist.sass): fix menu list items on IE11 #10717
fix(vlist.sass): fix menu list items on IE11 #10717
Conversation
On IE11 text in menu list items was not vertically centered. fix #10464
Was this a brute force fix or is there some flex knowledge you can bestow upon me? |
Fixed vertical text alignments in lists on IE11 fix #10464
@johnleider I have finally found the real cause of this bug. It is because on IE11 I have applied this workaround: Please check my changes again. |
Just applied refactoring from comment. fix #10464
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psuedo elements should use 2 colons
Pseudoelements should you double colon + removed unnecessary new line fix #10464
On IE11 text in menu list items was not vertically centered.
fix #10464
Description
Fixes #10464
On IE11 text in menu list items is not vertically centered. This PR fixes this issue.
Motivation and Context
I wanted to fix the bug which was occurring only on IE11.
How Has This Been Tested?
Because this is a visual bug I have not created any unit tests.
I have tested this PR manually. First I have checked if on IE11 the behavior is correct. Then I have checked on Chrome and Firefox to see if everything is working as before.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).