Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vtabs): fix blank space in slider on mobile devices #12446

Closed

Conversation

bhaskar-nair2
Copy link
Contributor

Added display classes to hide the arrow placeholder which created a blank space in the VTabs slider
on mobile devices.

fix #6932

Description

Motivation and Context

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
    <!--  -->
    <v-tabs
      color="primary"
      slider-color="primary"
      dark
    >
      <v-tab
        v-for="item in items"
        :key="item"
      >
        {{ item }}
      </v-tab>
    </v-tabs>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      //
      items: Array.from({ length: 10 }, (v, x) => x),
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Added display classes to hide the arrow placeholder which created a blank space in the VTabs slider
on mobile devices.

fix vuetifyjs#6932
@johnleider johnleider self-requested a review October 20, 2020 23:28
@johnleider johnleider added C: VTabs T: bug Functionality that does not work as intended/expected labels Oct 20, 2020
@johnleider johnleider added this to the v2.3.x milestone Oct 20, 2020
@bhaskar-nair2
Copy link
Contributor Author

Do I need to make any changes before this can get accepted?

@johnleider
Copy link
Member

This is on my list but currently lower priority.

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simply hides the space all together which conflicts w/ MD spec:
On mobile and desktop, offset the first tab on the left to signal that tabs are scrollable

also causes some bad UX when scrolling forward and then back with show-arrows prop

@johnleider
Copy link
Member

This Pull Request is being closed due to a conflicting change to MD spec.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider closed this Dec 19, 2020
@johnleider johnleider removed this from the v2.3.x milestone Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTabs T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-tabs bar missing offset on medium(?) viewports to indicate that scrolling is possible
3 participants