Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elevation): use correct CSS variable for ambient opacity #18998

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

brownsugar
Copy link
Contributor

@brownsugar brownsugar commented Jan 8, 2024

Description

Use a separate CSS variable key for ambient style as it has a different opacity value from penumbra, but currently, it's using the shared style of penumbra which makes us hard to customize the styles.

Markup:

<template>
  <v-app>
    <v-container>
      <v-btn>VBtn</v-btn>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    setup () {
      return {
        //
      }
    },
  }
</script>

<style>
:root {
  --v-shadow-key-umbra-opacity: rgba(0, 0, 0, .1);
  --v-shadow-key-penumbra-opacity: rgba(0, 0, 0, .07);
  --v-shadow-key-ambient-opacity: rgba(0, 0, 0, .06); /* Not working now */
}
</style>

@johnleider johnleider added this to the v3.4.x milestone Jan 9, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected sass labels Jan 9, 2024
@johnleider johnleider merged commit 3d59954 into vuetifyjs:master Jan 9, 2024
10 checks passed
@johnleider johnleider changed the title fix(elevation): use own CSS variable key for ambient opacity value fix(elevation): use correct CSS variable for ambient opacity Jan 9, 2024
tmasrat pushed a commit to tmasrat/vuetify that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sass T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants