Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDateInput): cancel action button should always be active #20483

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vikash8813
Copy link

fixes #20226

Description

This pull request fixes an issue where the cancel and ok button of date-input not enables, clearable does not clear the model value.

Changes Made

Add a prop in VConfirmEdit to show the action buttons and make it true from the VDateInput which enables the action buttons for the date input, VConfirmEdit for other inputs works same as before.

Testing:

Verified the fix locally by using multiple conditions in VDateInput.
All relevant tests are passing.

Recording

@vikash8813 vikash8813 changed the title Fix(VDateInput): Cancel action button should always be active Fix(VDateInput): cancel action button should always be active Sep 16, 2024
@vikash8813 vikash8813 changed the title Fix(VDateInput): cancel action button should always be active fix(VDateInput): cancel action button should always be active Sep 16, 2024
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VDateInput labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDateInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.13] VDateInput cancel action button should always be active.
2 participants