fix(VAppBar): vertical main layout shift on SSR request #20563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajesticPotatoe
added
T: bug
MajesticPotatoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we need to await to render the VToolbar from VAppBar, this PR just uses the props to calculate the computed height in VAppBar when VToolbar is not still present: on SSR page request this will prevent the vertical shift layout.
https://streamable.com/llbms5
resolves #15202 partially, now there is a flickering in the navigation drawer (we should also review the navigation drawer and the hydration missmatch): https://streamable.com/6pjzvc
related PR #15229
Markup: