Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTabs): margins in RTL mode #8123

Merged
merged 3 commits into from
Aug 1, 2019
Merged

fix(VTabs): margins in RTL mode #8123

merged 3 commits into from
Aug 1, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Jul 28, 2019

Description

Regression from #6932 + other RTL fixes

How Has This Been Tested?

visually

Markup:

<template>
  <div>
    <v-switch v-model=$vuetify.rtl label=rtl />

    <v-tabs>
      <v-tab v-for="i in 5" :key="i">Item {{ i }}</v-tab>
    </v-tabs>

    <v-tabs>
      <v-tab v-for="i in 5" :key="i" href="#">Item {{ i }}</v-tab>
    </v-tabs>

    <v-tabs align-with-title>
      <v-tab v-for="i in 50" :key="i">Item {{ i }}</v-tab>
    </v-tabs>

    <v-tabs align-with-title>
      <v-tab v-for="i in 50" :key="i" href="#">Item {{ i }}</v-tab>
    </v-tabs>
  </div>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke C: VTabs VTabs rtl labels Jul 28, 2019
@codecov
Copy link

codecov bot commented Jul 28, 2019

Codecov Report

Merging #8123 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8123      +/-   ##
==========================================
+ Coverage   85.76%   85.79%   +0.03%     
==========================================
  Files         334      334              
  Lines        9096     9095       -1     
  Branches     2420     2418       -2     
==========================================
+ Hits         7801     7803       +2     
+ Misses       1207     1204       -3     
  Partials       88       88
Impacted Files Coverage Δ
packages/vuetify/src/services/theme/index.ts 100% <0%> (ø) ⬆️
.../vuetify/src/components/VSlideGroup/VSlideGroup.ts 84.37% <0%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1565a8e...b76e5e5. Read the comment docs.

@johnleider johnleider merged commit e5e5f76 into master Aug 1, 2019
@johnleider johnleider deleted the fix/v-tabs-rtl branch August 1, 2019 15:23
@lock lock bot locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VTabs VTabs rtl T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants