Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VAppBar): fix elevation issue when extended #8519

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

morficus
Copy link
Contributor

@morficus morficus commented Aug 14, 2019

When using hide-on-scroll in combination with extended, elevate-on-scroll would not work
as expected.

fixes #8516

Description

When using hide-on-scroll in combination with extended, elevate-on-scroll would not work as expected.

Motivation and Context

fixes #8516

How Has This Been Tested?

Unit tests
Visually

Markup:

<template>
  <v-container>
    <div>
      <v-row justify="center">
        <v-col cols="3" md="2">
          <v-switch v-model="elevateOnScroll" label="Elevate-on-scroll"></v-switch>
        </v-col>
        <v-col cols="3" md="2">
          <v-switch v-model="hideOnScroll" label="Hide-on-scroll"></v-switch>
        </v-col>

        <v-col cols="3" md="2">
          <v-switch v-model="extended" label="Extended"></v-switch>
        </v-col>
      </v-row>
      <v-card class="overflow-hidden">
        <v-app-bar
          absolute
          scroll-target="#playground-example"
          :color="color"
          :elevate-on-scroll="elevateOnScroll"
          :hide-on-scroll="hideOnScroll"
          :fade-on-scroll="fadeOnScroll"
          :fade-img-on-scroll="fadeImgOnScroll"
          :inverted-scroll="invertedScroll"
          :collapse="collapse"
          :collapse-on-scroll="collapseOnScroll"
          :shrink-on-scroll="shrinkOnScroll"
          :extended="extended"
        >
          <v-app-bar-nav-icon></v-app-bar-nav-icon>

          <template v-slot:extension>This text is in the "extension" slot</template>

          <v-toolbar-title>Title</v-toolbar-title>

          <v-spacer></v-spacer>

          <v-btn icon>
            <v-icon>search</v-icon>
          </v-btn>
        </v-app-bar>

        <v-sheet id="playground-example" class="overflow-y-auto" max-height="600">
          <v-container style="height: 1500px;"></v-container>
        </v-sheet>
      </v-card>
    </div>
  </v-container>
</template>

<script>
export default {
  data: () => ({
    elevateOnScroll: true,
    hideOnScroll: true,
    extended: true,
    color: "white"
  })
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@morficus morficus force-pushed the issue-8516 branch 2 times, most recently from 47b7d1a to 7825f43 Compare August 14, 2019 03:21
@TravisBuddy
Copy link

TravisBuddy commented Aug 14, 2019

Hey @morficus,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: fbbea660-be44-11e9-8e8d-8dee9100a8b2

When using **hide-on-scroll** in combination with **extended**, **elevate-on-scroll** would not work
as expected.

fixes vuetifyjs#8516
@johnleider johnleider merged commit f676454 into vuetifyjs:master Aug 15, 2019
@morficus morficus deleted the issue-8516 branch August 16, 2019 01:38
@lock lock bot locked as resolved and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VAppBar - elevate-on-scroll + hide-on-scroll do not work as expected with "extension" slot
3 participants