Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): apply delay to visibility variants #184

Conversation

BobbieGoede
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It looks like the delay prop was not applied to variants in the same way as it did for directives, this fixes that. I also refactored the logic slightly to avoid repetition as well as make it more consistent between component and directive, this also acts as preparation to add support for a duration prop which will work just like delay.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Apr 19, 2024
Copy link
Member

@Tahul Tahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@BobbieGoede BobbieGoede changed the title fix(component): apply delay to visible and visibleOnce variants fix(component): apply delay to visibility variants Apr 20, 2024
@BobbieGoede BobbieGoede merged commit 7a77272 into vueuse:main Apr 20, 2024
5 checks passed
@NoelDeMartin
Copy link
Contributor

Hey @BobbieGoede, I'm looking at the code and I'm wondering why the shorthand properties only apply to enter, visible, and visibleOnce. Is there any particular reason why it doesn't apply to other variants such as leave or custom variants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants