-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: separate component logic, add <MotionGroup>
and tests
#187
feat: separate component logic, add <MotionGroup>
and tests
#187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great ; amazing work as always @BobbieGoede :)
Should we document the component now that you even tested it?
@Tahul Also, while I was writing tests I noticed the |
🔗 Linked issue
❓ Type of change
📚 Description
This is both the continuation and replacement of #186, after a closer look it appeared that the
<Motion>
component broke by the dependency updates. As mentioned there, these changes resolve #45, and remove a type (SVGAttributes
inMotoonProperties
type) of which I'm not sure what the impact is on existing projects.Since the
<Motion>
component isn't really documented at the moment I figured it would be safe to give it a refactor and see if some changes could be made. I separated its logic and added another component<MotionGroup>
, this component is used when wanting to apply motion configuration on its child nodes/slots, which I removed from the<Motion>
component, this makes it possible to no longer requireis
property as well. Please let me know if you have any feedback!I spent some time to figure out how to test both the
v-motion
directive as well as the<Motion>
component, hopefully we can expand on it more to keep things stable as we make changes.📝 Checklist