Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transition onComplete triggers after each property animation #189

Merged

Conversation

BobbieGoede
Copy link
Member

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

During work on #188 I ran into two issues which made it difficult to test variants using the transition onComplete function:

  • onComplete is called after every variant property animation completion
  • When the event variants feature is enabled, variant animations are triggered twice (instantly)

This PR expands on #188 by fixing those issues (so that PR description still applies), I created this separate PR because it touches on more than just the tests.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Apr 26, 2024
@BobbieGoede BobbieGoede merged commit e0dec92 into vueuse:main May 17, 2024
5 checks passed
@rylanharper
Copy link

I don't think this ever got pushed to the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants