Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x, y, z not accepting relative units #195

Merged
merged 4 commits into from
May 30, 2024

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented May 30, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #24

This changes the parsing of x, y and z properties to also allow other units (these are not validated) while keeping the default of transforming plain numbers to px units.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from Tahul May 30, 2024 09:27
@BobbieGoede BobbieGoede self-assigned this May 30, 2024
@BobbieGoede BobbieGoede marked this pull request as ready for review May 30, 2024 09:27
@BobbieGoede BobbieGoede changed the title [DRAFT] fix: x, y, z not accepting relative units fix: x, y, z not accepting relative units May 30, 2024
@Tahul Tahul merged commit 0abe4d0 into vueuse:main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative motion properties
2 participants