make visibilityHooks animation work if element is visible initially #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initially visible
xstevenyung
changed the title
xstevenyung
changed the title
|
I wish this wasn't closed. |
|
Personally, the fix in the PR make it worked but as stated, I have no clue if this fix has any side effect, so use at your own risk. Unfortunately, I have no more time to spend on this PR. Feel free to reopen one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I finally got time to dig a bit and found a way to make visible hooks work even if the element is visible from the start. But I'm not sure this solution doesn't affect other part of the project, so this is mainly a WIP proposition.
The issue was mainly that
useIntersectionObserverwhich all visibility hooks rely on doesn't detect intersection on first load when used in thecreatedlifecycle (probably because the target element is not mounted in the app yet).I changed the directive file to register on
mountedinstead, souseIntersectionObserverwould work even on first load, as I'm not familiar with the rest of the codebase, I'm guessing this is actually wrong andcreatedhook is used for a specific reason. I'm open to an alternative solution on this one.Cheers
Related issue:
#29