justify-content for navbar-left in bs-compat.scss #4054
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
approved these changes
Nov 4, 2024
|
@ThoWagen, should we rebase this onto release-10.1 for inclusion in the 10.0.1 release, or is it okay to wait until release 11.0? Since the bootstrap3 theme will be removed in the 11.0 release, perhaps it is worth backporting... but maybe it's useful for backward compatibility in 11.0 regardless of the status of the bootstrap3 theme. |
|
@demiankatz That makes sense! I rebased it. |
|
Sorry, I misunderstood how the rebasing works. Reverted that for now. |
|
@ThoWagen, it should just be a matter of resetting to the release-10.1 branch, reapplying your SCSS change, and then running the build script. If you want me to do that, I'm happy to help! |
ThoWagen
force-pushed
the
pull-request/justify-content-navbar-left
branch
from
60f48e0
to
18a0570
Compare
|
@demiankatz Thanks! The rebasing is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to
navbar-rightthis PR addsjustify-contentto thenavbar-leftclass in bs3-compat.scss.