This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
(VDB-570) Handle duplicate storage diffs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
- If processing a new diff for a row that already exists in the DB, ignore the error without logging or queueing - If processing a queued diff for a row that already exists, remove it from the queue
rmulhol
force-pushed
the
vdb-570-storage-duplicates
branch
from
51daecb to
36c4da3
Compare
m0ar
reviewed
May 3, 2019
| @@ -193,5 +193,5 @@ func composeAndExecute() { | |||
| func init() { | |||
| rootCmd.AddCommand(composeAndExecuteCmd) | |||
| composeAndExecuteCmd.Flags().BoolVarP(&recheckHeadersArg, "recheck-headers", "r", false, "whether to re-check headers for watched events") | |||
| composeAndExecuteCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5 * time.Minute, "how often to recheck queued storage diffs") | |||
| composeAndExecuteCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5*time.Minute, "how often to recheck queued storage diffs") | |||
There was a problem hiding this comment.
@rmulhol The format/resolution to supply this parameter in is unclear. Seconds?
There was a problem hiding this comment.
@m0ar duration takes a format like 5m30s - put some examples in the flags section of the composeAndExecute docs, but happy to augment/move that if you think that'd be helpful.
There was a problem hiding this comment.
Add it in the short-hand docs on this line as well? I'd never have guessed :D
m0ar
reviewed
May 3, 2019
| @@ -139,7 +139,7 @@ func execute() { | |||
| func init() { | |||
| rootCmd.AddCommand(executeCmd) | |||
| executeCmd.Flags().BoolVarP(&recheckHeadersArg, "recheck-headers", "r", false, "whether to re-check headers for watched events") | |||
| executeCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5 * time.Minute, "how often to recheck queued storage diffs") | |||
| executeCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5*time.Minute, "how often to recheck queued storage diffs") | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore the error without logging or queueing
it from the queue