Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading from life_out output buffer instead of life_in. #2198

Merged
merged 1 commit into from
May 3, 2023

Conversation

dsentinel
Copy link
Contributor

Game of life example GLSL code uses 2 buffers ( in and out) such that in is read and out written. Although the game seems to run correctly the out buffer is being read as input.

  1. [x ] Run cargo fmt on the changes.

  2. [ x] Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  3. [ x] Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

Changelog:

### Bugs fixed
- Game of life logic corrected.

@marc0246
Copy link
Contributor

marc0246 commented May 3, 2023

Thanks!

@marc0246 marc0246 merged commit 7741e00 into vulkano-rs:master May 3, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants