Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping attributes when using dualSrcBlend feature #2333

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Fuzzyzilla
Copy link
Contributor

  1. Update documentation to reflect any user-facing changes - in this repository.
    N/A, it was an internal bug

  2. Make sure that the changes are covered by unit-tests.
    Looks like shader module as a whole is missing unit tests :<

  3. Run cargo fmt on the changes.

  4. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  5. Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

This change allows for fragment shaders to make use of the dualSrcBlend feature of Vulkan 1.0, by assigning an index layout to color outputs. In vulkano 0.33.0, this causes a compile time error, and in the current master branch it causes a runtime error, due to detection of overlapping interface variables not taking index into account. This fixes that :>

Changelog:

### Bugs fixed
- fragment shaders cannot use `dual_src_blend` device feature due to interface errors

@Fuzzyzilla Fuzzyzilla changed the title Add interface entry for color index, check during overlap testing Fix overlapping attributes when using dualSrcBlend feature Sep 15, 2023
@Rua
Copy link
Contributor

Rua commented Sep 15, 2023

The shader interface handling is due an overhaul anyway, to solve issues like #1738. But this is useful in the meantime, thanks!

@Rua Rua merged commit 80ab3a8 into vulkano-rs:master Sep 15, 2023
3 checks passed
Rua added a commit that referenced this pull request Sep 15, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants