Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate validation in GenericMemoryAllocator #2336

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Remove duplicate validation in GenericMemoryAllocator #2336

merged 3 commits into from
Sep 28, 2023

Conversation

marc0246
Copy link
Contributor

Removes some duplicate validation that isn't needed anymore.

Changelog:

### Breaking changes
Changes to memory allocation:
- Merged `GenericMemoryAllocator::new_unchecked` into `GenericMemoryAllocator::new`.

@marc0246 marc0246 changed the title Generic memory allocator validation Remove duplicate validation in GenericMemoryAllocator Sep 21, 2023
@Rua Rua merged commit b494760 into vulkano-rs:master Sep 28, 2023
3 checks passed
Rua added a commit that referenced this pull request Sep 28, 2023
@Rua
#2336 changelog
56b051c
@marc0246 marc0246 deleted the generic-memory-allocator-validation branch September 28, 2023 15:51
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
Remove duplicate validation in GenericMemoryAllocator (vulkano-rs#2336
7e96d1b 
)

* Remove duplicate validation

* Merge `GenericMemoryAllocator::new[_unchecked]`

* Fix oopsie from earlier PR
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
vulkano-rs#2336 changelog
dadb888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc0246 @Rua