Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if 0 (but not None) timeout would solve crash #2543

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

hakolao
Copy link
Contributor

@hakolao hakolao commented Jul 3, 2024

Potential help for #2524

I can't repro the issue on my Windows machine, so unsure what to do. This fix may potentially help.

@daveh86
Copy link

daveh86 commented Jul 17, 2024

Just ran a check on this myself as I could repro.

Some(0) fails, but None succeeds, so looks like the issue.

Digging through, it looks like the timeout just defaults to u64::Max so I went the other way and increased the timeouts.

For my Linux box (arch + plasma + wayland + nvidia prop driver), a timeout of 25ms seems sufficient when the window is in focus. However, while writing this comment i noted that the crash would occur when I swapped focus to Firefox, meaning the pipeline is slowed or halted when the window is not in focus.

@Rua
Copy link
Contributor

Rua commented Jul 18, 2024

Why not just use a timeout of 1 second? That's more than is reasonably enough.

@hakolao
Copy link
Contributor Author

hakolao commented Jul 18, 2024

Why not just use a timeout of 1 second? That's more than is reasonably enough.

Let's try that

@Rua
Copy link
Contributor

Rua commented Jul 21, 2024

Yeah that fixed it.

@Rua Rua merged commit db4657d into vulkano-rs:master Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants