pkg.json test script
#77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to change the github action? |
|
cc @louisinger |
|
UPDATE
|
altafan
reviewed
Nov 1, 2022
| @@ -37,7 +37,8 @@ | |||
| "nobuild:unit": "npm run mocha:ts -- --timeout 60000 'test/*.ts'", | |||
| "prettier": "prettier 'ts_src/**/*.ts' 'test/**/*.ts' --ignore-path ./.prettierignore", | |||
| "prettierjs": "prettier 'src/**/*.js' --ignore-path ./.prettierignore", | |||
| "test": "npm run build && npm run format:ci && npm run lint && npm run nobuild:coverage", | |||
| "checks": "npm run build && npm run format:ci && npm run lint && npm run nobuild:coverage", | |||
| "test": "npm run build && npm run nobuild:unit && npm run nobuild:integration", | |||
There was a problem hiding this comment.
Suggested change
| "test": "npm run build && npm run nobuild:unit && npm run nobuild:integration", | |
| "test": "npm run nobuild:unit && npm run nobuild:integration", |
There was a problem hiding this comment.
@louisinger we should use these commands in the gh action.
There was a problem hiding this comment.
@louisinger we should use these commands in the gh action.
There was a problem hiding this comment.
better to keep several steps in the GH actions, test is for local testing only @altafan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testscript is now renamed astest:ci(check formatting, prettier, lint etc...)testlets to launch unit and integration testsit closes #60
@tiero @altafan please review